Create cid #21
Merged
Create cid #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2019
nelsonic
reviewed
Jan 28, 2019
mix.exs
Outdated
| {:ex_multihash, "~> 2.0"} | ||
| {:ex_multihash, "~> 2.0"}, | ||
| {:jason, "~> 1.1"}, | ||
| {:cid, git: "git@github.com:SimonLab/ex-cid.git"} |
There was a problem hiding this comment.
This project should not have a dependency on ex-cid.
|
@nelsonic I have updated this now 👍 |
nelsonic
reviewed
Jan 29, 2019
| @@ -33,6 +33,7 @@ defmodule Cid do | |||
| iex> Cid.cid([1,2,3,"four"]) | |||
| "invalid data type" | |||
| """ | |||
| @spec cid(String.t | map() | struct()) :: String.t | |||
|
@RobStallion & @Danwhy good work on adding property-based-testing. 🎉 |
|
@nelsonic Will do. |
nelsonic
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
@RobStallion looking much better. Thanks! 🎉
Can't wait to apply this to our https://github.com/dwyl/phoenix-ecto-append-only-log-example 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create functions that create same CIDs as IPFS. Function takes a string, map or struct.
Currently uses ex_cid#7 #11
Have (temporarily) renamed the module to ex_cid. See #22 for more info on this.
Adds tests and doc tests.